FishEye and Crucible

merging 2.9 branch changes into the trunk

CYKLO-644: configuration option add_document_visual_editor added, when false (default) plain text -> html conversion routine is used (tag removal, newline to paragraph translation)

CYKLO-643: Save attachments descriptions changes action fixed.

CYKLO-636: Include document tumbnail to document propose attachment file resources. Save and Update proposal action modified.

CYKLO-639: HTMLService.removeEmptyParas invocation added to isValid(HTMLService) (invoked from actions) and cleanupContent(HTMLService) (invoked from views)

CYKLO-625: disabled HTML stripping and newline to paragraph translation for newly proposed documents (visual editor support)

CYKLO-620: setAttachments method in ProposedDocumentData class modified to set only FileResoureces. getAttachmentDescription method modified to prevent from indexOutOfRange exception.

CYKLO-630: fromNode method modified to set only FileResources to proposedDocumentData.attachments. SaveProposedChanges action at save attachments section changed.

CYKLO-613: an overhaul of text handling that will hopefully fix those problems for good. Basically, we HTML-entity encode the text on the way to the browser and the proposal XML document, we HTML-entity decode the text on the way from the browser and proposal document, and we strip HTML tags on the way from the browser and from general (administrator - edited) document. Content is treated differently: basically unchanged, except from toNode method used when submitting new documents.

CYKLO-613: refactoring HTML striping into separate methods

CYKLO-613: changed attachment id handing in fromParmeters method for consistency

CYKLO-613: introducing quot / unqot methods into fromParameters / toTemplatingContext

CYKLO-614: Save action method for ReviewProposedChanges modified to allow accept, reject and save option.

CYKLO-611: make cleanupContent logic generally available as a static method

CYKLO-609: fold successive newlines into one

CYKLO-601: Field editorial note added to proposed document data component.

CYKLO-538: Attachment description added to attachment section on ReviewProposedChanges screen. Null reference attachments list bug fixed.

CYKLO-538: prevent NPE when document contains no content

CYKLO-595: clean up document content before passing on to the simplified editor. Don't frustrate the user with markup they are unable to edit.

CYKLO-538: don't call enc() multiple times. This should prevent strange behaviour with &quot; and similar showing up in document attributes. This also prevents striping <p> tags generated for newline-terminated blocks of text on original proposed content.

CYKLO-593: store content attribute in proposa wrapped in CDATA node, it contains sanitized XHTML now.

CYKLO-593: added HTML validation and cleanup to PDD.isValid() method, adjusted API

CYKLO-593: removed unused parameter

CYKLO-570: track the location of the node where proposal of changes was submitted. this is needed to look up component configuration in the administrative screens

CYKLO-570: provide default value for attachmentDirId. It will not be used unless attachmentsEnabled == true

CYKLO-570: NPE protection

CYKLO-570: backend for requesting document removal

CYKLO-570: expose attachments List for the benefit of review screen / action

CYKLO-538: Defined selectedCategories in fromProposal method.

CYKLO-570: trivial bugfix

CYKLO-538: undoing some unwarranged formatting changes

CYKLO-538: Add new section "documents proposed changes" on EditorialTasks screen. Getters added to class ProposedDocumentData. New ReviewProposedChanges screen added.

CYKLO-570: don't attempt to handle attachments when disabled in component config (NPE protection)

CYKLO-570: really delete submitted but not yet published files

CYKLO-570: attachment releated tweaks

CYKLO-570: initialize attachment, attachmentDescription lists correctly

CYKLO-570: fixed XPath expression for metadata retrieval

CYKLO-570: more attachment related refactorings

CYKLO-570: refactoring - more attachment related logic moved to ProposedDocumentData

CYKLO-570: refactoring - moved file upload validation to ProposedDocumentData - will be shared with UpdateProposedContent action

CYKLO-570: storage of proposed changes in proposedContent field as XML

CYKLO-570: retrieval proposed changes from XML stroed in proposedContent field

CYKLO-570: use explicit procedural approach to metadata building

CYKLO-570 handle attachments state variables correctly in fromParameters method

CYKLO-573: moved metadata specific methods to a separate utility class, cleaned up and documented API

CYKLO-573: Interface cleanup

CYKLO-573: refactoring pulling HTMLService interface down to ledge-components, in order to consolidate it with HTML handling code in ledge-forms

CYKLO-573: refactoring: use HTMLService

CYKLO-570: descriptions handling for new and existing attachments

CYKLO-570: component configuration variables were placed in the data object. inheritCategories and calendarTree are not supposed to be user configurable, they removed from the form. part of attachment code were moved to the data object, more code that should be shared between add & edit use cases remains to be factored out from ProposeDocument action

CYKLO-570: added/improved logic for handling categories, related resources in ProposedDocumentData

CYKLO-570: added handling of some more fields in fromNode(..)

CYKLO-570: implemeted fromNode method and shuffled around meta processing

CYKLO-570: further refactoring - moved part of action logic into data object

CYKLO-570: refactoring - the extracted bits will be useful for impelementig document edit screen