FindBugs Results

The following document contains the results of FindBugs - http://findbugs.sourceforge.net/. This isn't formatted like a pretty CheckStyle / JDepend sheet as the FindBugs XML output is very terse and does not describe what each error type is. We have no desire to hardcode messages against FindBugs, so we'll wait until FindBugs XML output can be modified to produce easy to use messages. 

M UrF: Unread field: pl.caltha.forms.FormToolFactory.log
M UrF: Unread field: pl.caltha.forms.internal.FormsServiceImpl.reloadFormDefinitions
M SIC: Should pl.caltha.forms.internal.FormsServiceImpl$FormData be a _static_ inner class?
M Dm: pl.caltha.forms.internal.model.Bind.evalProperty(String,InstanceReference,InstanceImpl,pl.caltha.forms.internal.ui.ReferenceNode,boolean) invokes dubious Boolean constructor; use Boolean.valueOf(...) instead  At Bind.java:[line 200]
M MS: pl.caltha.forms.internal.ui.ActionEvent.ACTIVATE isn't final but should be
M MS: pl.caltha.forms.internal.ui.ActionEvent.DELETE isn't final but should be
M MS: pl.caltha.forms.internal.ui.ActionEvent.INSERT isn't final but should be
M MS: pl.caltha.forms.internal.ui.ActionEvent.RECALCULATE isn't final but should be
M MS: pl.caltha.forms.internal.ui.ActionEvent.REVALIDATE isn't final but should be
M MS: pl.caltha.forms.internal.ui.ActionEvent.SCROLL_FIRST isn't final but should be
M MS: pl.caltha.forms.internal.ui.ActionEvent.SCROLL_LAST isn't final but should be
M MS: pl.caltha.forms.internal.ui.ActionEvent.VALUE_CHANGED isn't final but should be
M ES: Comparison of String objects using == or != in pl.caltha.forms.internal.ui.DescriptionAll.addChild(Node)   At DescriptionAll.java:[line 64]
M ES: Comparison of String objects using == or != in pl.caltha.forms.internal.ui.DescriptionCaption.addChild(Node)   At DescriptionCaption.java:[line 34]
M SIC: Should pl.caltha.forms.internal.ui.NodeControlDate$DateValue be a _static_ inner class?
M UCF: Useless control flow in pl.caltha.forms.internal.ui.NodeControlFormatted.<init>(String,org.xml.sax.Attributes)  At NodeControlFormatted.java:[line 31]
M LI: Incorrect lazy initialization of static field pl.caltha.forms.internal.ui.NodeControlHTML.tidyConfiguration in pl.caltha.forms.internal.ui.NodeControlHTML.init(UI)  At NodeControlHTML.java:[lines 149-151]
L Nm: Confusing to have methods pl.caltha.forms.internal.ui.NodeForm.getEnctype() and pl.caltha.forms.internal.model.SubmitInfo.getEncType()
M UrF: Unread field: pl.caltha.forms.internal.ui.NodeForm.ui
M ES: Comparison of String objects using == or != in pl.caltha.forms.internal.ui.Reference.getValue(org.dom4j.Node)   At Reference.java:[line 250]
M UrF: Unread field: pl.caltha.forms.internal.ui.actions.Dispatch.bubbles
M UrF: Unread field: pl.caltha.forms.internal.ui.actions.Dispatch.cancelable
M ES: Comparison of String objects using == or != in pl.caltha.forms.internal.util.CSSParser.parse(String)   At CSSParser.java:[line 27]
L DE: pl.caltha.forms.internal.util.Util.expandURI(String,String) might ignore java.lang.Exception  At Util.java:[line 203]
L DE: pl.caltha.internal.xml.Localizer.addBundle(String) might ignore java.util.MissingResourceException  At Localizer.java:[line 40]
M Se: Class pl.caltha.internal.xml.validation.IDConstraintTypeDetector$AmbiguousDocumentException defines non-transient non-serializable instance field pl.caltha.internal.xml.validation.IDConstraintTypeDetector.this$0  At unknown source line
M SIC: Should pl.caltha.services.xml.CollectingErrorHandler$ErrorInfo be a _static_ inner class?
M UrF: Unread field: pl.caltha.services.xml.validation.DOM4JValidationErrorCollector.currentNode