Ledge Web
The following document contains the results of FindBugs - http://findbugs.sourceforge.net/. This isn't formatted like a pretty CheckStyle / JDepend sheet as the FindBugs XML output is very terse and does not describe what each error type is. We have no desire to hardcode messages against FindBugs, so we'll wait until FindBugs XML output can be modified to produce easy to use messages.
M UwF: Unwritten field: org.objectledge.modules.actions.authentication.Impersonate.logger M UwF: Unwritten field: org.objectledge.modules.actions.authentication.Impersonate.userManager L SIC: Should org.objectledge.modules.actions.logging.SaveConfiguration$1 be a _static_ inner class? L SIC: Should org.objectledge.modules.actions.logging.SaveConfiguration$2 be a _static_ inner class? L SIC: Should org.objectledge.modules.components.authentication.LoggedInUsers$1 be a _static_ inner class? M SIC: Should org.objectledge.modules.views.logging.Loggers$LoggerDescriptor be a _static_ inner class? M Dm: org.objectledge.modules.views.scheduler.CreateJob.process(org.objectledge.templating.TemplatingContext) invokes dubious Boolean constructor; use Boolean.valueOf(...) instead At CreateJob.java:[line 67] M Dm: org.objectledge.modules.views.scheduler.EditJob.process(org.objectledge.templating.TemplatingContext) invokes dubious Boolean constructor; use Boolean.valueOf(...) instead At EditJob.java:[line 77] M Dm: org.objectledge.modules.views.scheduler.Jobs.process(org.objectledge.templating.TemplatingContext) invokes dubious Boolean constructor; use Boolean.valueOf(...) instead At Jobs.java:[line 67] L SIC: Should org.objectledge.modules.views.system.Versions$1 be a _static_ inner class? M SIC: Should org.objectledge.table.TableStateManagerImpl$TableData be a _static_ inner class? M EI: org.objectledge.table.generic.AbstractTableModel.getColumns() may expose internal representation by returning org.objectledge.table.generic.AbstractTableModel.columns At AbstractTableModel.java:[line 90] M EI: org.objectledge.table.generic.BaseGenericRowSet.getRows() may expose internal representation by returning org.objectledge.table.generic.BaseGenericRowSet.rows At BaseGenericRowSet.java:[line 101] L SIC: Should org.objectledge.table.generic.GenericListRowSet$1 be a _static_ inner class? M EI: org.objectledge.table.generic.PathTreeTableModel.getColumns() may expose internal representation by returning org.objectledge.table.generic.PathTreeTableModel.columns At PathTreeTableModel.java:[line 109] M EI: org.objectledge.upload.UploadContainer.getBytes() may expose internal representation by returning org.objectledge.upload.UploadContainer.data At UploadContainer.java:[line 169] M RR: org.objectledge.upload.UploadContainer.load(java.io.InputStream,int) ignores result of java.io.InputStream.read(byte[],int,int) At UploadContainer.java:[line 105] M Se: Class org.objectledge.web.LedgeServlet defines non-transient non-serializable instance field org.objectledge.container.LedgeContainer.container At unknown source line L Se: Class org.objectledge.web.LedgeServlet defines non-transient non-serializable instance field org.objectledge.web.HttpDispatcher.dispatcher At unknown source line M EI: org.objectledge.web.RequestTrackingValve.getDataSources() may expose internal representation by returning org.objectledge.web.RequestTrackingValve.DATA_SOURCES At RequestTrackingValve.java:[line 450] M EI: org.objectledge.web.RequestTrackingValve.getGraphs() may expose internal representation by returning org.objectledge.web.RequestTrackingValve.GRAPHS At RequestTrackingValve.java:[line 442] L ES: Comparison of String objects using == or != in org.objectledge.web.mvc.finders.MVCFinder.findEnclosingViewName(String) At MVCFinder.java:[line 194] M EI: org.objectledge.web.mvc.security.Policy.getRoles() may expose internal representation by returning org.objectledge.web.mvc.security.Policy.roles At Policy.java:[line 129] L SIC: Should org.objectledge.web.mvc.tools.PageTool$1 be a _static_ inner class? M SIC: Should org.objectledge.web.mvc.tools.PageTool$Meta be a _static_ inner class? M SIC: Should org.objectledge.web.mvc.tools.PageTool$ScriptLink be a _static_ inner class? M SIC: Should org.objectledge.web.mvc.tools.PageTool$StyleLink be a _static_ inner class? M RV: org.objectledge.web.mvc.tools.UserAgentTool.prepareUAInfo(org.objectledge.web.HttpContext) ignores return value of java.lang.String.trim() At UserAgentTool.java:[line 230] M SIC: Should org.objectledge.web.test.LedgeWebTestCase$TableContentPredicate be a _static_ inner class?